Repository navigation
Reusable DBSqlRowTableWithSideBar Component - #1171
Conversation
🦋 Changeset detectedLatest commit: 6938e81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Stably Runner - Test Suite - 'Smoke Test'Test Suite Run Result: 🟢 Success (0/4 tests passed) [dashboard] This comment was generated from stably-runner-action |
|
Z-Index issue with tables in dashboard tile creation Nested panel UX consideration (Can be a separate ticket) If you click on an item within the table in the first panel, another panel opens up but the first cannot be accessed again. |
|
@teeohhem thanks for finding those bugs, they are fixed! |
Across the app, we are inconsistent with when we can open the sidebar and expand functionality. This is because the sidebar and logic was managed by the parent component. Additionally, the expand logic was set to assume a certain structure that some places in the application could not support (ex clickhouse dashboard doesn't have a 'source'). As a result, I have created the `DBSqlRowTableWithSideBar` component which will manage a lot of the common use cases for us. This PR introduces that new component, and updates all references (that could be easily upgraded) to use the new component when applciable. The result: a lot less duplicate code (see # of lines removed) and the ability to more easily maintain the components down the road. This PR also fixes several bugs I found as I tested these flows, especially around sidebars opening subpanels. Fixes: HDX-2341
Across the app, we are inconsistent with when we can open the sidebar and expand functionality. This is because the sidebar and logic was managed by the parent component.
Additionally, the expand logic was set to assume a certain structure that some places in the application could not support (ex clickhouse dashboard doesn't have a 'source').
As a result, I have created the
DBSqlRowTableWithSideBarcomponent which will manage a lot of the common use cases for us. This PR introduces that new component, and updates all references (that could be easily upgraded) to use the new component when applciable.The result: a lot less duplicate code (see # of lines removed) and the ability to more easily maintain the components down the road.
This PR also fixes several bugs I found as I tested these flows, especially around sidebars opening subpanels.
Fixes: HDX-2341